fix: HTTPWalletWire uses injected httpClient instead of global fetch#224
Merged
sirdeggen merged 1 commit intoJun 23, 2026
Merged
Conversation
transmitToWallet called the global fetch directly, silently dropping the injected httpClient. This prevented wrapping requests with AuthFetch for BRC-103 mutual auth and prevented injecting a custom/mock fetch. The sibling HTTPWalletJSON already uses its injected httpClient. With the default constructor httpClient defaults to global fetch, so existing behavior is preserved. Adds a regression test asserting the injected client is used; fixes a stale comment/test name that documented the old behavior.
sirdeggen
approved these changes
Jun 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
HTTPWalletWireaccepts and stores anhttpClientconstructor parameter, buttransmitToWalletcalls the globalfetchdirectly — so the injected client is silently dropped.This makes it impossible to:
AuthFetchfor BRC-103 mutual authentication (auth headers are dropped → requests go out unauthenticated and are rejected by an auth-protected server);The sibling substrate
HTTPWalletJSONalready uses its injectedhttpClient, so this is an inconsistency rather than intentional — it dates back to when theHttpClientabstraction was replaced with nativefetch: the constructor parameter was kept and re-typed totypeof fetch, but the body was changed to call the globalfetch(...)instead ofthis.httpClient(...).Fix
transmitToWalletnow callsthis.httpClientinstead of the globalfetch. BecausehttpClientdefaults to the globalfetch, existing behavior is unchanged.Tests
fetchis not). It fails without this fix and passes with it.HTTPWalletWiretests pass (44/44).